Add support for NTK-by-Part Rotary Embedding & set correct rotary base for Llama-3.1 series #763
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Thanks to #691 and #761 for proposing and supporting Llama-3.1 models in TL.
However two modifications made on rotary embedding is not implemented here.
This PR implements both changes and significantly decreases max logit diff from >1 to about 0.2 for Llama-3.1-8B/
No dependency is required for this change.
Type of change
Screenshots
Please attach before and after screenshots of the change if applicable.
Checklist: