Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hooked encoder #732

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Type hooked encoder #732

merged 2 commits into from
Sep 26, 2024

Conversation

bryce13950
Copy link
Collaborator

Description

Redo of #727 to make sure the history is squashed

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Screenshots

Please attach before and after screenshots of the change if applicable.

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

bryce13950 and others added 2 commits September 12, 2024 23:25
@bryce13950 @hannamw @FlyingPumba
Redo of #713 (#722)
87edf1d 
* adding option to ungroup gqa

* adding option to ungroup gqa

* updating gqa / rebasing

* Update HookedTransformerConfig.py

* formatting fix

* renaming ungroup_gqa option

* Add tests for ungroup_grouped_query_attention flag

---------

Co-authored-by: Michael Hanna <[email protected]>
Co-authored-by: Ivan Arcuschin <[email protected]>
@bryce13950
fixed typo
1b927fb
@bryce13950 bryce13950 merged commit 764d653 into dev Sep 26, 2024
22 checks passed
@bryce13950 bryce13950 deleted the type-hooked-encoder branch September 26, 2024 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bryce13950