Add skip_verbose_naming in add_hook to give an option for skipping the naming #635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Like the proposal mentioned in issue, running
full_hook._name_ = (hook._repr_())
in add_hook may cause large overhead in some situation. This PR add a new parameterskip_verbose_naming
that allows user to skip this line.Fixes #631
Type of change
Please delete options that are not relevant.
Screenshots
The overhead caused by naming being removed by adding
skip_verbose_naming=True
inwith model.hooks(fwd_hooks=fwd_hooks, skip_verbose_naming=True):
.Checklist:
There is some problem with the current unit test here:
After my changes, the parameter would be different for add_hook. Should I do anything about it?