Support digest function in GrpcStore #1509
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bility - Updated `ResourceInfo` to default `digest_function` to `sha256` if not provided. - Ensured backward compatibility for existing functionality. - Updated tests to reflect default `sha256` behavior when `digest_function` is not set
|
|
asr2003
changed the title
asr2003
changed the title
|
I don't understand the comment? |
|
I mean before digest function is None when not explicitly provided inResourceInfo
Now we added fallback behaviour as sha256
PS: FIXED
|
|
@aaronmondal @MarcusSorealheis It's ready for your review! |
|
@asr2003 Please squash this into one commit |
|
Sorry @MarcusSorealheis . I have messed up this branch during rebase. Instead I have opened #1548 , a new PR with clean and squashed all of them into one |
|
Closing in favor of #1548 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ResourceInfoto defaultdigest_functiontosha256if not provided.Fixes #1325
/claim #1325
Type of change
Please delete options that aren't relevant.
How Has This Been Tested?
Please also list any relevant details for your test configuration
Checklist
bazel test //...passes locallygit amendsee some docsThis change is