Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide the ability to link to system simdjson #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mgorny
Copy link

@mgorny mgorny commented May 23, 2021

Bundling a library is a serious sin in our book, so provide the ability to link to the system library. I've also done some refactoring to avoid exponential growth of Extension calls. The default behavior remains the same, so it shouldn't affect existing users.

That said, the patch isn't perfect. It still uses the bundled headers instead of system headers but it should be good enough for us.

Refactor setup.py in order to avoid declaring Extension() twice.
Instead, use a bunch of helper vars that get filled conditionally
and create Extension() once.  This should reduce the maintenance effort,
as well as pave way for more conditions.
@TkTech
Copy link
Owner

TkTech commented May 23, 2021

Happy to support this as an opt-in. I'm assuming this is for Gentoo, in which case the package maintainer will ensure its linking against the right version? Or do we need to do a sanity in the setup.py?

@mgorny
Copy link
Author

mgorny commented May 23, 2021

Yes, we'll handle the right deps ourselves, as well as stripping simdjson.h to ensure linking against the system header (I couldn't think of an easy way to do that).

@edgarsi edgarsi mentioned this pull request Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants