Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: log a warning when CH terminated prematurely #1362

Merged
merged 10 commits into from
Jan 29, 2025
Merged

feat: log a warning when CH terminated prematurely #1362

merged 10 commits into from
Jan 29, 2025

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jan 28, 2025

No description provided.

@triceo triceo requested a review from zepfred January 28, 2025 10:06
@triceo triceo linked an issue Jan 28, 2025 that may be closed by this pull request
If the solver ends before an init event (if the CH doesn't finish), log a warning in the log. #1353
Closed
@triceo triceo had a problem deploying to documentation (preview) January 29, 2025 08:03 — with GitHub Actions Failure
zepfred
zepfred requested changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@zepfred zepfred left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems solid. I have two primary suggestions:

  1. Create a new abstract class to reuse logic.
  2. Add a new upgrade recipe.

zepfred
zepfred approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@triceo triceo merged commit 6537668 into TimefoldAI:main Jan 29, 2025
28 of 29 checks passed
@triceo triceo deleted the log branch January 29, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepfred zepfred zepfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If the solver ends before an init event (if the CH doesn't finish), log a warning in the log.
2 participants
@triceo @zepfred