Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for visualizing Bavet node graph #1306

Merged
merged 13 commits into from
Jan 7, 2025

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jan 7, 2025

No description provided.

@triceo triceo marked this pull request as ready for review January 7, 2025 09:18
@triceo triceo self-assigned this Jan 7, 2025
@triceo triceo added this to the v1.18.0 milestone Jan 7, 2025
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic looks great, and I liked the result. However, it's still unclear about how much publicity we should give this feature.

I believe it deserves some documentation and possibly some examples about generating and converting it to SVG.

@triceo
Copy link
Contributor Author

triceo commented Jan 7, 2025

@zepfred I did think about it, and I decided I'll keep this hidden for now. If we see people asking, we can always open it up.

I believe users shouldn't have to understand this. I believe users should just write nice, clean constraints, and have it be our job to make sure they perform well. By exposing this widely and telling people to use it, I invite micro-optimization, and yet another API surface. Neither of which I want.

@triceo triceo merged commit 0f2da1e into TimefoldAI:main Jan 7, 2025
27 of 28 checks passed
@triceo triceo deleted the graph branch January 7, 2025 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants