Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce a Ruin And Recreate move #1010

Merged
merged 36 commits into from
Aug 27, 2024
Merged

feat: introduce a Ruin And Recreate move #1010

merged 36 commits into from
Aug 27, 2024

Conversation

triceo
Copy link
Contributor

@triceo triceo commented Jul 31, 2024 •
edited
Loading

Introduces a Ruin and Recreate move for both basic and list variable. (Not chained.)

Also introduces a largely refactored "Optimization algorithms" section of the documentation.
It moves away from "everything on a single page" approach, and breaks the content down by topic - just as we already do for many other topics.

@triceo triceo linked an issue Jul 31, 2024 that may be closed by this pull request
Ruin & recreate moves #550
Closed
triceo and others added 20 commits August 26, 2024 20:46
@triceo
chore: clean up the CH
a256a5b
@triceo
chore: sonar
c94dacd
@triceo
chore: add tabu support
d658dc9
@triceo
chore: don't allow custom selector config
4a5c33d
@triceo
chore: improve default config for list r&r
0567fc2
@triceo
chore: rename the moves
7cd7e58
@triceo
docs: refactor optimization algorithms
6c27d68 
# Conflicts:
#	docs/src/modules/ROOT/pages/optimization-algorithms/optimization-algorithms.adoc
#	docs/src/modules/ROOT/pages/responding-to-change/responding-to-change.adoc
@triceo
fix: spring Native
1af0352
@triceo
docs: document the new moves
3c7df0c
@triceo
chore: replace entityCount with valueCount
a92130c
@triceo
chore: clean up
b6d9b83
@triceo
docs: minor tweaks
889db2c
@triceo
chore: even more separation of ruin
612b87a
@triceo
chore: formatting
8589339
@triceo @zepfred
Apply suggestions from code review
b7ae228 
Co-authored-by: Frederico Gonçalves <[email protected]>
@triceo
Use int instead of long
2c5e921
@triceo
Rename method
15d0cd7
@triceo
chore: code review
3ab2ad5
@triceo
chore: sonar
b40bb27
@triceo
chore: address conflicts from upstream
5517441
@triceo triceo force-pushed the ruin-and-recreate branch from eaa1ed0 to 5517441 Compare August 27, 2024 06:22
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
78.3% Coverage on New Code
2.2% Duplication on New Code

See analysis details on SonarCloud

zepfred
zepfred approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@zepfred zepfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactoring looks excellent. Thanks for addressing that!

Please double-check the logic still works with the new changes before merging it.

@triceo triceo merged commit 85e6812 into TimefoldAI:main Aug 27, 2024
27 checks passed
@triceo triceo deleted the ruin-and-recreate branch August 27, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepfred zepfred zepfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruin & recreate moves
3 participants
@triceo @zepfred @Christopher-Chianelli