Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve CI #552

Merged
merged 1 commit into from
Aug 20, 2024
Merged

chore: improve CI #552

merged 1 commit into from
Aug 20, 2024

Conversation

zepfred
Copy link
Contributor

@zepfred zepfred commented Aug 19, 2024

Description of the change

This PR improves the CI script.

Checklist

Development

  • The changes have been covered with tests, if necessary.
  • You have a green build, with the exception of the flaky tests.
  • UI and JS files are fully tested, the user interface works for all modules affected by your changes (e.g., solve and analyze buttons).
  • The network calls work for all modules affected by your changes (e.g., solving a problem).
  • The console messages are validated for all modules affected by your changes.

Code Review

  • This pull request includes an explanatory title and description.
  • The GitHub issue is linked.
  • At least one other engineer has approved the changes.
  • After PR is merged, inform the reporter.

@zepfred zepfred requested a review from triceo August 19, 2024 21:41
triceo
triceo approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@triceo triceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll see what it does when we merge it.

@triceo triceo merged commit 7a1ba29 into TimefoldAI:development Aug 20, 2024
40 checks passed
@zepfred zepfred deleted the fix-ci3 branch August 26, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@triceo triceo triceo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zepfred @triceo