Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test requirements, adjust and streamline CI YAML #674

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sgillies
Copy link
Collaborator

This moves the requirements files to a new /ci folder, updates the YAML, and removes some unneeded installation when building wheels. The goal: get all of us developers to use exactly the same dependencies defined in pyproject.toml.

@sgillies sgillies self-assigned this Oct 22, 2024
@@ -233,8 +233,7 @@ jobs:

- name: Build wheel
run: |
pip install --upgrade pip build wheel setuptools setuptools-scm
pip install -r requirements-py3.9.txt
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build dependencies are defined in pyproject.toml and will be fetched by our build backend. The test dependencies aren't needed at build time.

@spencerseale
Copy link
Collaborator

spencerseale commented Oct 22, 2024

Can we just install from pyproject.toml within ci and remove requirements.txt files altogether?

@sgillies
Copy link
Collaborator Author

@spencerseale From my perspective, changing our CI environment is a different matter. Switching from a requirements file, with versioning pinning, to the largely unpinned specs in pyproject.toml means that our CI builds will be less reproducible and will start to fail occasionally due to changes that we ourselves have not made to cloud-py. Let's have a discussion about that, but not as a part of this PR, okay?

@spencerseale
Copy link
Collaborator

@sgillies yes that sounds good, but I was definitely pushing for pinning within a pyproject.toml PEP631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants