Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve missing object detection in upload_wheel #655

Merged
merged 3 commits into from
Sep 24, 2024

Conversation

gspowley
Copy link
Member

upload_wheel uses tiledb.object_type(...) to check for existing objects.

  • tiledb-py<=0.31.1 returns None (NoneType) if the object doesn't exist.
  • tiledb-py>=0.32.0 returns "None" (a string) if the object doesn't exist.

This PR updates the upload_wheel to handle both return values.

@spencerseale
Copy link
Collaborator

Guessing we'll follow-up with tiledb-py to revert that to NoneType? Thanks @gspowley!

@gspowley gspowley merged commit 1a3ec49 into main Sep 24, 2024
18 checks passed
@gspowley gspowley deleted the gspowley/fix-upload-wheel branch September 24, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants