Improve missing object detection in upload_wheel #655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ihnorton
approved these changes
Sep 24, 2024
Co-authored-by: Isaiah Norton <[email protected]>
|
Guessing we'll follow-up with tiledb-py to revert that to NoneType? Thanks @gspowley! |
spencerseale
approved these changes
Sep 24, 2024
sgillies
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
upload_wheelusestiledb.object_type(...)to check for existing objects.tiledb-py<=0.31.1returnsNone(NoneType) if the object doesn't exist.tiledb-py>=0.32.0returns"None"(a string) if the object doesn't exist.This PR updates the
upload_wheelto handle both return values.