Only follow a limited number of redirects. #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgillies
approved these changes
Sep 17, 2024
| ) | ||
| if not (200 <= probe.status < 300 or probe.status == 405): | ||
| # Once we reach the end, we should get either 405 Method Not Allowed | ||
| # or some form of OK (2xx). If not, that's an error. |
| # While we're probably at the place we want to end up posting to, | ||
| # we might still get redirected. This time, we need to handle redirects | ||
| # manually, since we have to rewind the request body each time. | ||
| redirects_left = 3 | ||
| while True: |
There was a problem hiding this comment.
@thetorpedodog your use of the walrus operation suggested to me that we could use more built-in Python features. Maybe this?
Suggested change
| while True: | |
| while redirects_left > 0: | |
| ... | |
| else: | |
| raise tce.TileDBCloudError.from_response(resp) |
There was a problem hiding this comment.
I thought about doing something like this, but ended up with the structure we have now, because all the dealing with the response needs to happen in a try/finally for each individual request, so this was the best structure.
HAVING SAID THAT this made me realize that I think we need to release the connection for the HEAD request as well!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a comment from the previous review, and a realization about how we can use
urllib3’sresponse.url.