Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put urllib3.BaseHTTPResponse annotation in quotes. #588

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

thetorpedodog
Copy link
Contributor

The latest release of tiledb-cloud on PyPI has an import exception when used with old versions of urllib3, which don’t include the BaseHTTPResponse class. We only use that in an annotation, and it’s the only thing from recent urllib3 that we use, so by putting it in quotes, we can avoid evaluating it and triggering the error.

The latest release of tiledb-cloud on PyPI has an import exception
when used with old versions of urllib3, which don’t include the
BaseHTTPResponse class. We only use that in an annotation, and it’s
the only thing from recent urllib3 that we use, so by putting it
in quotes, we can avoid evaluating it and triggering the error.
@thetorpedodog thetorpedodog merged commit 41adb97 into main Jun 12, 2024
18 checks passed
@thetorpedodog thetorpedodog deleted the urllib-annotation branch June 12, 2024 17:55
JohnMoutafis added a commit that referenced this pull request Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants