Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the article 'parts' subdivision, as marked on the TODO list #2

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

NaelsonDouglas
Copy link

@NaelsonDouglas NaelsonDouglas commented Feb 3, 2023

This PR solves the following problem which is cited on the TODO list

Many WikiHow articles also contain "Parts" which break down further into sub-steps. Write a function to parse these additional divisions.

Now the Step object has a field 'part' which keeps the name of the "parent topic" of that object

Example:
Let's say we have an article on this format

Part 1
Step1=Do A
Step2=Do B

Part 2
Step3=Do C
Step4=Do D

Then we can use the package normally, but when accessing 'step1' we can check where it lives using step1.part, which in this case is 'Part 1'. The same result would fetched when calling 'step2.part'

@JarbasAl
Copy link
Contributor

JarbasAl commented Feb 3, 2023

thanks for sending a PR!

at first sight this looks good, I will only be able to test later but if everything checks out i will get it merged and make a new release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants