Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apple only: exit FL_Window fullscreen if active in order to minimize. #1813

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

rudironsonijr
Copy link
Contributor

No description provided.

@LMattsson
Copy link
Contributor

Thank you for both finding and making a fix for this issue, it doesn't seem to have been reported previously.

I looked into this in detail, here's a summary:

Confirmed the bug with TigerVNC 1.14.0 on macOS 14.5. While in fullscreen, nothing happens when I try to minimise from the F8-menu. In windowed mode, minimise works fine. Also confirmed that minimise work after the fix.

One theory was that macOS native fullscreen was involved in this issue, since TigerVNC doesn't work well with that. I tested a few different things that gave me conflicting information:

  1. Tested building vncviewer with macOS native fullscreen off, but I could still see the minimise bug. One indication that native fullscreen is off is that the green button in the top bar of the window shows a '+' when hovered, instead of 2 arrows pointing away from each other. Could see that the green button had shifted to a '+' for this new build.

  2. Tested building vncviewer on another machine with FLTK v. 1.3.7 and macOS SDK v. 10.6. When running this build on the original machine, minimise worked when fullscreen was entered from the F8-menu. When I entered fullscreen natively (clicking the green button with 2 arrows in top bar), minimise did not work.

Since minimise did work in case 2, this fix seems to act more like a workaround than targeting the core issue. As a side note, the vncviewer ends up in windowed mode after un-minimising the window, not fullscreen mode, but this is still an improvement from the current behaviour.

It's probably better to wait finding the core issue until we get more clues about it. I'll go ahead and merge this.

@LMattsson LMattsson merged commit 3979e3c into TigerVNC:master Aug 23, 2024
11 checks passed
LMattsson added a commit to LMattsson/tigervnc that referenced this pull request Aug 27, 2024
An issue with minimise not working when in fullscreen on macOS was
workaround in Pull Request TigerVNC#1813. The underlaying issue is currently
unknown.

macOS native fullscreen mode was looked into, but no clear answer was
given. See TigerVNC#1813 for details.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants