vncconfig: add option to force view-only remote client connections, round 2 #1701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's better to use a mnemonic symbol rather than zero to initialize the accessRights members. Signed-off-by: Carlos Santos <[email protected]>
Make accessRights a member of SSecurity, not of subclasses, so we don't need to override getAccessRights(). Also avoid shadowing the member in SSecurityStack::getAccessRights(). This is in preparation for changes that will allow to force connections to view-only access. Signed-off-by: Carlos Santos <[email protected]>
Specifies that the server must ignore all keyboard or mouse events sent by the client. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2180903 Signed-off-by: Carlos Santos <[email protected]>
casantos
force-pushed
the
casantos-rhbz_2180903-2
branch
from
0f1e644
to
d8cb2ef
Compare
|
I agree, this is indeed a bit too invasive and not what I had in mind. The Security classes should not need to deal with this as this has nothing to do with them. The "view only" restriction should be merged with the security restrictions from the security types. So likely in But let's continue on the first PR to avoid confusion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation of #1670 frankly I don't like it, since it's too intrusive and affects all SSecurity subclasses.