-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fill, docstring, istypes, benchmark #30
Conversation
draft. |
Ready for review. jk not yet. now its ready. removed is_categorical because I will just throw that in TidierCats to minimize adding new deps. |
Thank you for working on this! Will take a look this weekend. My VSCode is acting up right now. |
Nice job on fixing the doctests! I'll got through these next week. There's a lot in this PR, so I want to make sure we get each new macro/function right. I agree with moving |
Sounds good. Only thing I couldn't figure out was the doc test output for slice_sample because it shows a random set of rows. I tried setting a seed but that did not work either so I suppressed output w ; |
I have ideas on how to fix. |
…o pr/drizk1/30
… a new file. Updated NEWS.md. Bumped version to 0.11.0.
No worries about the failing tests, has to do with dependencies. Will come back to this. |
… instead of tuples or arrays.
Updated slurping to be compatible with older versions of Julia.
I was unable to get parse_across to support the predicate functions, so the is_type do not have much functionality right now but included are is_float, is_integer, is_string.
fill_missing macro + docstring + example
slice_sample macro + docstring + addended slice in user guide
added a benchmarking file to the docs. it may totally miss the mark with delivery. I am happy to revise as needed.