refactor: rm the open_or_go_to arg from file_created_dance

ThinkR-open · Aug 27, 2024 · 0480655 · 0480655
1 parent 598fc7f
commit 0480655
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 14 deletions.
diff --git a/R/after_creation_msg.R b/R/after_creation_msg.R
@@ -123,21 +123,16 @@ file_created_dance <- function(
   dir,
   name,
   open_file,
-  open_or_go_to = TRUE,
   catfun = cat_created
 ) {
   catfun(where)
 
   fun(pkg, dir, basename(where))
 
-  if (open_or_go_to) {
-    open_or_go_to(
-      where = where,
-      open_file = open_file
-    )
-  } else {
-    return(invisible(where))
-  }
+  open_or_go_to(
+    where = where,
+    open_file = open_file
+  )
 }
 
 file_already_there_dance <- function(

diff --git a/R/use_files_external_tools.R b/R/use_files_external_tools.R
@@ -77,7 +77,6 @@ perform_checks_and_download_if_everything_is_ok <- function(
     pkg = pkg,
     dir = directory_to_download_to,
     open_file = open,
-    open_or_go_to = FALSE,
     catfun = cat_downloaded
   )
 }
diff --git a/R/use_files_internal_tools.R b/R/use_files_internal_tools.R
@@ -75,7 +75,6 @@ perform_checks_and_copy_if_everything_is_ok <- function(
     pkg = pkg,
     dir = directory_to_copy_to,
     open_file = open,
-    open_or_go_to = FALSE,
     catfun = cat_copied
   )
 }
diff --git a/tests/testthat/_snaps/after_creation_msg.md b/tests/testthat/_snaps/after_creation_msg.md
@@ -26,9 +26,10 @@
       File downloaded at inst/app/www/myhtml
     Code
       file_created_dance("inst/app/www", after_creation_message_sass, "mypkg",
-        "inst/app/www", "mysass", open_file = FALSE, open_or_go_to = FALSE)
+        "inst/app/www", "mysass", open_file = FALSE)
     Output
       v File created at inst/app/www
+      * Go to inst/app/www
     Code
       file_already_there_dance("inst/app/www", open_file = FALSE)
     Output

diff --git a/tests/testthat/test-after_creation_msg.R b/tests/testthat/test-after_creation_msg.R
@@ -41,8 +41,7 @@ test_that("after_creation_msg works", {
       "mypkg",
       "inst/app/www",
       "mysass",
-      open_file = FALSE,
-      open_or_go_to = FALSE
+      open_file = FALSE
     )
     file_already_there_dance(
       "inst/app/www",