Improving error handling support for web and some improvements for sentry handler #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ons in web environment
Adding runZonedGuarded for web platform to catch asynchronous excepti…
…eptions are caught for both web and native platforms
Fixing timing of init widgets binding to catch async errors in web
…ersion instead of a space
Fixing sentry release syntax by using an @ sign between appname and version
…gurable-server-name Feature/improved message and configurable server name
…ndler Lowercasing appname
* Fix directive formatting * Bump version and add changelog * Support custom file names during runtime Fixes ThexXTURBOXx#21 * Allow file supplier to use info from report Fixes ThexXTURBOXx#22 * Update CMakeLists * Allow sentry versions 8.x * Bump version and add changelog * Update version and fix some typos * Undo version upgrade and fix a few more things * Fix linter rules for Dart 3.3.0 * Bump version and add changelog * Update example to newest standards * Fix FileHandler not sending reports * Clean up FileHandler * Bump version and add changelog * Update package_info_plus to v6 * Allow device_info_plus 10.0.0 to be used * Bump version and add changelog * Update dependencies * Bump version and add changelog * Allow package_info_plus versions 8.x * Bump version and add changelog * Remove direct dependency on platform interface * Migrate Slack screenshots to new API calls * Remove superfluous log * Better example structure * Update flutter_lints * Migrate screenshots to XFiles * Workaround for error catching on Web --------- Co-authored-by: Nico Mexis <[email protected]> Co-authored-by: Martin Clauss <[email protected]> Co-authored-by: Bartlomiej Tartanus <[email protected]> Co-authored-by: Michael Söderman <[email protected]>
Merge from upstream 20240520 2
|
Firstly, thank you very much for your PR! |
ThexXTURBOXx
added a commit
that referenced
this pull request
May 20, 2024
|
I have merged your changes with a few changes. Again, thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know that it isn't ideal that a PR contains multiple fixes but I don't really have time to split it up into smaller chunks. I've tested that these features works as intended but I'm more than happy for more testers and/or feedback to these changes.
Until these features are merged, I will continue to use our forked repo.
Edit: I didn't update the pubspec.yaml version because I'm not sure if and when this will be merged. But the pubspec.yaml version needs to be bumped if this gets merged (of course).