Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OAuth client authorizations delete request #7381

Open
wants to merge 1 commit into
base: v3.33
Choose a base branch
from

Conversation

mjamescompton
Copy link
Contributor

@mjamescompton mjamescompton commented Nov 12, 2024

Summary

Close #7350

Changes

  • Move attachPromise inside dispatch

Testing

Steps

Open the console at /console/user-settings/authorizations
Click on one of the clients and click Revoke authorization

Results
Regressions

...

Notes for Reviewers

Screen.Recording.2024-11-13.at.09.37.38.mov

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@mjamescompton mjamescompton self-assigned this Nov 12, 2024
@mjamescompton mjamescompton requested a review from a team as a code owner November 12, 2024 15:35
@github-actions github-actions bot added the ui/web This is related to a web interface label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OAuth client authorizations state not updated on delete
1 participant