Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth client authorizations state not updated on delete #7350

Open
1 of 6 tasks
mjamescompton opened this issue Oct 21, 2024 · 1 comment · May be fixed by #7381
Open
1 of 6 tasks

OAuth client authorizations state not updated on delete #7350

mjamescompton opened this issue Oct 21, 2024 · 1 comment · May be fixed by #7381
Assignees
Labels
bug Something isn't working c/console This is related to the Console
Milestone

Comments

@mjamescompton
Copy link
Contributor

Summary

When you delete an OAuth client from /console/user-settings/authorizations the state fails to update and refresh is required

Steps to Reproduce

Open the console at /console/user-settings/authorizations
Click on one of the clients and click Revoke authorization

Current Result

The list page will open with the same result, but refreshing the page will remove the one you deleted

Expected Result

After clicking Revoke authorization the client should not be in the list

Relevant Logs

No response

URL

No response

Deployment

The Things Stack Cloud

The Things Stack Version

3.32

Client Name and Version

No response

Other Information

No response

Proposed Fix

Screenshot 2024-10-21 at 12 02 23

It looks like the list request is made for awaiting the delete to succeed. I would start by checking out why

Contributing

  • I can help by doing more research.
  • I can help by implementing a fix after the proposal above is approved.
  • I can help by testing the fix before it's released.

Validation

Code of Conduct

@mjamescompton mjamescompton added the needs/triage We still need to triage this label Oct 21, 2024
@mjamescompton mjamescompton self-assigned this Oct 21, 2024
@KrishnaIyer KrishnaIyer added bug Something isn't working c/console This is related to the Console and removed needs/triage We still need to triage this labels Oct 21, 2024
@KrishnaIyer KrishnaIyer added this to the v3.33.0 milestone Oct 21, 2024
@KrishnaIyer
Copy link
Member

So based on the Slack thread here: https://thethingsindustries.slack.com/archives/C06UQSMPB/p1729502918133949

Seems like we don't wait for the success of the DELETE request before requesting a GET. @mjamescompton I guess the implementation here is straightforward?

@mjamescompton mjamescompton linked a pull request Nov 12, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working c/console This is related to the Console
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants