Skip to content
This repository has been archived by the owner on Jun 11, 2021. It is now read-only.

Birth and death disabled #20

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

Yaroslav1996
Copy link

-Checkbox control removed from both campaign creation menu and from campaign menu
-Birth and death are disabled by default

image

image

@Z3rca Z3rca requested review from hunharibo, Finu, tristanka and Z3rca May 30, 2021 10:09
@Z3rca
Copy link
Collaborator

Z3rca commented May 30, 2021

I can't run it in visual studio, but in steam.

@Yaroslav1996
Copy link
Author

Since option controls are hardcoded in the CharacterCreationOptionsStageVM constructor, it wouldn't be possible to make a custom stage without remaking a large part of the code, and we can't say how changing the other difficulty options would affect the game in other areas.

Copy link
Collaborator

@Z3rca Z3rca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after some discussions with Yaroslav I think the current Harmony patch is a good solution. However, when Taleworlds might change their code, we could revisit this problem, and are hopefully then able to solve the problem over method extensions and loading our submodules. Everything else is too much of a hassle for now in my opinion

@Yaroslav1996 Yaroslav1996 force-pushed the disableLifeDeathCycle branch from 59ee3f9 to 776d965 Compare June 7, 2021 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants