Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation: Sanity check there are enough members #610

Merged

Conversation

Asartea
Copy link
Contributor

@Asartea Asartea commented Sep 22, 2024

Because

This PR

  • Adds a sanity check: if there are less than two members in the queue and the actionType isn't add or remove, it immediately returns with a message

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project Contributing Guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Callbacks command: Update verbiage
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If this PR adds new features or functionality, I have added new tests
  • If applicable, I have ensured all tests related to any command files included in this PR pass, and/or all snapshots are up to date

@MaoShizhong MaoShizhong self-requested a review September 23, 2024 15:03
@MaoShizhong
Copy link
Contributor

Will review after merging #611 because you'll likely need to resolve a small merge conflict.

@MaoShizhong MaoShizhong merged commit fb2b009 into TheOdinProject:main Sep 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants