Remove 40 char API Key Validation (#145) #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove 40char api key validation * fix migrate button * changelog
* track variable * remove exe * changelog * changelog * fix gui localusername * fix MTP with Form * changelog * autobind fix
jworkmanjc
requested changes
Dec 3, 2024
There was a problem hiding this comment.
Two things to change,
-
Cleaning up the tests that we have skipped now
-
Making that file useful for customers
-
Migration of a user that has a local user account ✅
-
Migration of a user on an MTP Org ✅
-
Migration of a user that fails a step after the "merge" step does not remove the local user account ✅. This shouldn't trigger because we are not failing any steps after the merge step at the moment but even if someone adds that now, I see that the migrated accounts is there, logging in shows the expected "completion" window and brings me into the new account.
gweinjc
previously approved these changes
Dec 3, 2024
jworkmanjc
approved these changes
Dec 4, 2024
gweinjc
approved these changes
Dec 4, 2024
kmaranionjc
temporarily deployed
to
Production
GitHub Actions
Inactive
kmaranionjc
temporarily deployed
to
PublishToPSGallery
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove 40char api key validation
fix migrate button
changelog
Issues
What does this solve?
Is there anything particularly tricky?
How should this be tested?
Screenshots