Implementation of orc2 based jit engine. #477
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
alright I feel I have commented everything. Feel free to let me know anything i missed. |
|
hmmm sees i need to find out what llvm version LLJIT was added. And then rebase to master. I'll get right on that! |
Comment on lines
+80
to
+81
| /// execution engine it came from, but adding functions after calling this | ||
| /// method *may* invalidate the function pointer. |
There was a problem hiding this comment.
There is probably a cool hack to avoid this: accept &mut self in add_* methods and store &self in LLJITFunction. In theory, this should prevent from calling mutable methods, while there is an immutable reference
There was a problem hiding this comment.
Just like you can't store references to Vec elements and push into it
TheDan64
reviewed
Apr 4, 2024
| @@ -184,6 +186,7 @@ impl<'ctx> Module<'ctx> { | |||
| Module { | |||
| module: Cell::new(module), | |||
| owned_by_ee: RefCell::new(None), | |||
| owned_by_lljit : RefCell::new(None), | |||
There was a problem hiding this comment.
I wonder if we should just have one owned by field with an enum in the option?
TheDan64
reviewed
Apr 4, 2024
| self.add_global_mappings_impl(mappings.iter().map(|(name,addr)| (to_c_str(name),*addr))) | ||
| } | ||
|
|
||
| fn add_global_mapping_impl(&self,name:Cow<'_,CStr>, addr:usize) -> Result<(),LLVMString> { |
TheDan64
force-pushed
the
master
branch
3 times, most recently
from
b7ef5f6
to
7684346
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It supports creating the LLJIT engine off a module (consuming said module), adding global mappings off name and global values.
Documentation needs a bit of work (thus starting this as a draft pr) but rather simple implementation and tried to mirror
JITExecutionEnginethough it is constructed differently.Related Issue
#476
How This Has Been Tested
I have tested with a local project referencing the local fork and the samples attached to
LLJITExecutionEngine::get_functionandLLJITExecutionEngine::add_global_mappingChecklist