Improves readability in BaseHeightMapRenderObjClass::Get_Height_Map_Height #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #917 +/- ##
===========================================
- Coverage 2.53% 2.53% -0.01%
===========================================
Files 949 949
Lines 110293 110299 +6
Branches 18881 18881
===========================================
Hits 2800 2800
- Misses 107089 107095 +6
Partials 404 404 ☔ View full report in Codecov by Sentry. |
|
The variable name convention for non-member non-global is lowercase with underscore: my_variable_name. |
Updated, thanks! |
xezon
previously requested changes
May 16, 2023
xezon
changed the title
xezon
reviewed
May 16, 2023
xezon
reviewed
May 17, 2023
xezon
reviewed
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.