Reduce file string allocations #788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomsons26
approved these changes
Feb 5, 2024
tomsons26
force-pushed
the
optimize-file-string-alloc
branch
from
4369b5c to
39e15bb
Compare
xezon
force-pushed
the
optimize-file-string-alloc
branch
from
39e15bb to
be3b654
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #788 +/- ##
========================================
Coverage 2.53% 2.53%
========================================
Files 949 949
Lines 110292 110293 +1
Branches 18881 18881
========================================
+ Hits 2799 2800 +1
Misses 107089 107089
Partials 404 404 ☔ View full report in Codecov by Sentry. |
|
Tested and works correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces unnecessary string allocations in file class. Optimization.
The way it works is
Utf8Stringis reference counted. So by having a static string, constructor can borrow this static and simply increase its ref count when assigning it. It no longer needs to allocate this"<no file>"string, effectively elimitating 1 wasted allocation per file open.