Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement remaining shadow code #1042

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Jan 12, 2024

No description provided.

@jonwil jonwil requested a review from xezon January 12, 2024 21:35
@jonwil jonwil force-pushed the shadow branch 4 times, most recently from ae5dccb to 8ecb038 Compare January 12, 2024 22:26
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

Attention: 1104 lines in your changes are missing coverage. Please review.

Comparison is base (24d413c) 2.69% compared to head (6af3c60) 2.66%.
Report is 1 commits behind head on develop.

Files Patch % Lines
...rm/w3dengine/client/shadow/w3dvolumetricshadow.cpp 0.00% 667 Missing ⚠️
src/platform/w3dengine/client/w3dview.cpp 0.00% 339 Missing ⚠️
src/platform/w3dengine/client/shadow/w3dshadow.cpp 0.00% 82 Missing ⚠️
...form/w3dengine/client/shadow/w3dvolumetricshadow.h 0.00% 7 Missing ⚠️
src/platform/w3dengine/client/w3dview.h 0.00% 4 Missing ⚠️
...rm/w3dengine/client/drawable/draw/w3dmodeldraw.cpp 0.00% 2 Missing ⚠️
src/platform/w3dengine/client/w3dingameui.cpp 0.00% 2 Missing ⚠️
...orm/w3dengine/client/shadow/w3dprojectedshadow.cpp 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1042      +/-   ##
===========================================
- Coverage     2.69%    2.66%   -0.03%     
===========================================
  Files          919      921       +2     
  Lines       103723   104832    +1109     
  Branches     17579    17793     +214     
===========================================
+ Hits          2797     2799       +2     
- Misses      100522   101629    +1107     
  Partials       404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shadows from airborne objects are glitching in Shell Map.

I removed all hooks that this change has added and it still happens.

shot_20240114_103221_5

shot_20240114_103224_6

Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in one session with

  • Shell Map
  • A few Skirmish maps
  • Test map with all faction objects

Shadow length and direction looks identical.

No crashes. No issues with Shadows found.

@jonwil jonwil merged commit 1bc69b0 into TheAssemblyArmada:develop Jan 15, 2024
7 checks passed
@jonwil jonwil deleted the shadow branch January 15, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants