-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement remaining shadow code #1042
Conversation
ae5dccb
to
8ecb038
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #1042 +/- ##
===========================================
- Coverage 2.69% 2.66% -0.03%
===========================================
Files 919 921 +2
Lines 103723 104832 +1109
Branches 17579 17793 +214
===========================================
+ Hits 2797 2799 +2
- Misses 100522 101629 +1107
Partials 404 404 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in one session with
- Shell Map
- A few Skirmish maps
- Test map with all faction objects
Shadow length and direction looks identical.
No crashes. No issues with Shadows found.
No description provided.