Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final bits of W3DView #1040

Merged
merged 1 commit into from
Jan 8, 2024
Merged

Final bits of W3DView #1040

merged 1 commit into from
Jan 8, 2024

Conversation

jonwil
Copy link
Contributor

@jonwil jonwil commented Jan 7, 2024

No description provided.

@jonwil
Copy link
Contributor Author

jonwil commented Jan 7, 2024

USA01 and GLA01 play through with no issues.

@codecov-commenter
Copy link

Codecov Report

Attention: 343 lines in your changes are missing coverage. Please review.

Comparison is base (24d413c) 2.69% compared to head (18f92b6) 2.68%.

Files Patch % Lines
src/platform/w3dengine/client/w3dview.cpp 0.00% 337 Missing ⚠️
src/platform/w3dengine/client/w3dview.h 0.00% 4 Missing ⚠️
src/platform/w3dengine/client/w3dingameui.cpp 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1040      +/-   ##
===========================================
- Coverage     2.69%    2.68%   -0.01%     
===========================================
  Files          919      921       +2     
  Lines       103723   104063     +340     
  Branches     17579    17623      +44     
===========================================
  Hits          2797     2797              
- Misses      100522   100862     +340     
  Partials       404      404              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/platform/w3dengine/client/w3dview.cpp Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Outdated Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Show resolved Hide resolved
src/platform/w3dengine/client/w3dview.cpp Show resolved Hide resolved
Copy link
Contributor

@xezon xezon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Camera appears to behave as usual.

Shellmap looks as usual.
Mission camera intros work.
Camera zoom and blur work in Generals Challenge as usual.
Camera shake work as usual.
Camera controls work as usual.

No crashes.

@jonwil jonwil merged commit 49ca309 into TheAssemblyArmada:develop Jan 8, 2024
7 checks passed
@jonwil jonwil deleted the view3 branch January 8, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants