fix: async dispose for FileSystemStream (#1163)

Fix #1162
TestableIO · Nov 8, 2024 · 4ef1c3a · 4ef1c3a
1 parent 17464e6
commit 4ef1c3a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 9 deletions.
diff --git a/src/TestableIO.System.IO.Abstractions/FileSystemStream.cs b/src/TestableIO.System.IO.Abstractions/FileSystemStream.cs
@@ -223,15 +223,6 @@ protected override void Dispose(bool disposing)
             base.Dispose(disposing);
         }
 
-#if FEATURE_ASYNC_FILE
-        /// <inheritdoc cref="Stream.DisposeAsync()" />
-        public override async ValueTask DisposeAsync()
-        {
-            await _stream.DisposeAsync();
-            await base.DisposeAsync();
-        }
-#endif
-
         /// <summary>
         /// Allows to cast the internal Stream to a FileStream
         /// </summary>

diff --git a/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamTests.cs b/tests/TestableIO.System.IO.Abstractions.TestingHelpers.Tests/MockFileStreamTests.cs
@@ -283,6 +283,18 @@ public void MockFileStream_Null_ShouldReturnSingletonObject()
 
             Assert.That(result1, Is.SameAs(result2));
         }
+
+        #if FEATURE_ASYNC_FILE
+        [Test]
+        public async Task MockFileStream_DisposeAsync_ShouldNotThrow()
+        {
+            var fileSystem = new MockFileSystem();
+            fileSystem.File.WriteAllText("foo.txt", "");
+            {
+                await using var reportStream = fileSystem.File.OpenRead("foo.txt");
+            }
+        }
+        #endif
 
         [Test]
         public void MockFileStream_Null_ShouldHaveExpectedProperties()