Fix 7296 wmts #7371
Open
Fix 7296 wmts #7371
+1,535
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
reviewed
Dec 14, 2024
pjonsson
reviewed
Dec 14, 2024
pjonsson
reviewed
Dec 14, 2024
pjonsson
reviewed
Dec 14, 2024
| : [layer.ResourceURL]; | ||
|
|
||
| if (resourceUrls && (this.requestEncoding === "RESTful" || !url)) { | ||
| for (let i = 0; i < resourceUrls.length; i++) { |
There was a problem hiding this comment.
Could for (const resourceUrl of resourceUrls) { be used to iterate over the content so the next line can be omitted, or is there some JavaScript-reason to always use index-based iterations in TypeScript?
Same comment for the other for-loops where the index is only used to get the element.
zoran995
force-pushed
the
fix-7296-wmts
branch
from
eeaecab to
8a8b5a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes #7296, #2927, #1573
Extended OWS common interfaces lists and added support for reading the URL from operations metadata.
Test me
Try adding data using the init file https://gist.githubusercontent.com/zoran995/10169b47c7c7191f4795b56878c3d9c4/raw/0a9cdbc3bdde67cec67ae4fdcd5f8a370b702161/terriajs-7296-config.json
I have also tested using New Zealand LINZ data service mentioned in #2927
Checklist
doc/.