Improve default formats #7262
Open
Improve default formats #7262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljowen
reviewed
Sep 5, 2024
| definition: { | ||
| type: "wms" | ||
| type: "wms-group" |
There was a problem hiding this comment.
Would this change impact singular WMS layers matching the regex?
There was a problem hiding this comment.
I think it will become one member group.
ljowen
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Fixes https://github.com/TerriaJS/nsw-digital-twin/issues/674
How to test
before
after
After expanding the group, search keyword "instrument" in the catalog. Then go to
Digital Earth Australia Hotspots, testing item with typeWMSand URL ending withwms.Environmental Planning Instrument - Acid Sulfate Soils, testing item with typeMap Serviceand URL ending withMapServer?f=pjson.Environmental Planning Instrument - Acid Sulfate Soils/Protection, testing item with typeMap Serviceand URL ending withMapServer/1?f=pjson.Transitional - Excluded Land, testing item with typeImageServerand URL ending withImageServer.All of the above tests will fail in before.
Checklist
doc/.