Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TableStructureSpec: use right var #7206

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

pjonsson
Copy link
Contributor

What this PR does

The other tests create a TableStructure
object and then calls loadFromJson on
that object, so do the same in the last
test.

Test me

Test only changes.

Checklist

  • There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • I've updated relevant documentation in doc/.
  • I've updated CHANGES.md with what I changed.
  • I've provided instructions in the PR description on how to test this PR.

@pjonsson pjonsson force-pushed the tablestructurespec-right-var branch from aa26df5 to 6bfdef9 Compare June 23, 2024 18:27
@na9da
Copy link
Collaborator

na9da commented Oct 22, 2024

The file test/Map/TableStructureSpec.js and test/Map/TableColumnSpec.js are stale. It might be better to remove them instead.

@pjonsson
Copy link
Contributor Author

@na9da alright, fixed!

Thanks for getting the merge-train going again. It would be nice to get #7218 merged so an upper bound for mobx version is added. And also ESLint 8 (#7150) since it shouldn't affect TerriaJS itself, but brings you one major version closer to the latest version.

Copy link
Collaborator

@na9da na9da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pjonsson!

@na9da na9da merged commit c64dd05 into TerriaJS:main Oct 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants