Extra personalization of internationalization #7178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ra-personalization-of-internationalization-frommain
|
|
arte-dev
changed the title
|
@arte-dev, Sorry, it took a while for us to review the PR. Would you be able to merge the latest main into your branch and move the line in CHANGES.md under Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Allow to modify
lookupCookiefor i18next. This is in line with current implementation, but it certainly would be better if all options could be overwritten. This is needed to be able to take advantage of the existing domain cookie that manages the languageTest me
Use cookie on changeLanguageOnStartWhen and change lookupCookie to the desired value. Change the language and you'll see the proper value on the cookie with name lookupCookie
Checklist
doc/.