-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1757 new routing #3494
Closed
Closed
1757 new routing #3494
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
f16b9df
wip catalog routing
soyarsauce bfbb88d
Remove duplicate link style
soyarsauce 735741a
wip catalog routing
soyarsauce 363aef1
Update routing to use const
soyarsauce db6ae8c
Add gorup routing & add graceful preview errors
soyarsauce 4f8e624
Update catalog item html titles & meta descriptions
soyarsauce 3f5994b
Update docs for baseHref
soyarsauce 392d214
Add rel="canonical" link tags for DataPreview helmet
soyarsauce 6851830
Add prerender end event for catalog routes
soyarsauce cfa920e
Lint
soyarsauce 046f546
Merge remote-tracking branch 'origin/master' into 1757-new-routing
soyarsauce 6955c5c
Export non-withRouter-hoc components
soyarsauce 1a150e2
Fix DataCatalogItemSpec `selected` prop tests
soyarsauce 9b19cb7
Merge remote-tracking branch 'origin/master' into 1757-new-routing
soyarsauce b168ab7
Track page views
soyarsauce 444df22
Resolve quick minor comments from PR
soyarsauce 994f4b1
Fix haeding structure
soyarsauce 158f9ba
Fix "About This Data" & preview map reload bug
soyarsauce 66084ef
Fix group-selected-state & open on first load
soyarsauce da13136
Fix tabs not updating when navigating
soyarsauce 1e6fa60
Merge remote-tracking branch 'origin/master' into 1757-new-routing
soyarsauce 8435d8a
Fix incorrect "About This Data" open-close flow
soyarsauce 6b8b521
Merge remote-tracking branch 'origin/master' into 1757-new-routing
soyarsauce 533e6da
Merge remote-tracking branch 'origin/master' into 1757-new-routing
soyarsauce 7301a84
Bump version, fix bad merge
soyarsauce 230d8da
Merge remote-tracking branch 'origin/master' into 1757-new-routing
soyarsauce 6515f2c
Lint
soyarsauce 40f4351
Update add user data button (bandage)
soyarsauce 5da6ad6
Bump version
soyarsauce 5ea5986
Merge tag '7.11.3' into 1757-new-routing
tephenavies e77fa4b
Merge tag '7.11.4' into 1757-new-routing
reginapramesti aeb6e1d
Run prettier
reginapramesti 1f3d1f7
Create prerender-troubleshooting.md
soyarsauce 7c89cde
feedback form is now scrollable
KeyboardSounds d5fe95d
new version 7.4.11-prerender-1
KeyboardSounds File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
# Prerender Troubleshooting | ||
TerriaMap prerenders pages through puppeteer. | ||
It should JustWork on MacOS. Linux will require some extra deps. Some more general troubleshooting at: | ||
https://github.com/puppeteer/puppeteer/blob/master/docs/troubleshooting.md | ||
|
||
## WSL | ||
You'll need to tell PrerenderSPAPlugin to pass an `executablePath` down to puppeteer. | ||
|
||
via @steve9164's findings | ||
|
||
Add (changing the path to where your chrome is) | ||
`executablePath: '/mnt/c/Program\ Files\ \(x86\)/Google/Chrome/Application/chrome.exe'` | ||
|
||
to | ||
|
||
https://github.com/TerriaJS/TerriaMap/blob/c8675bc62cd5e37b6df490910f6ed7f7ae264d95/buildprocess/webpack.config.js#L155 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
// Route paths for the app. | ||
|
||
var ROOT_ROUTE = "/"; | ||
|
||
var CATALOG_ROUTE = `${ROOT_ROUTE}catalog/`; | ||
// var CATALOG_ROUTE = "/catalog/"; | ||
|
||
var CATALOG_MEMBER_ROUTE = `${CATALOG_ROUTE}:catalogMemberId`; | ||
|
||
module.exports = { | ||
ROOT_ROUTE, | ||
CATALOG_ROUTE, | ||
CATALOG_MEMBER_ROUTE | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does this need a 300ms delay?