Fix deprecation warnings in tests #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Buffer() is deprecated according to the warnings when running tests.
4 tasks
na9da
reviewed
May 22, 2024
spec/proxy.spec.js
Outdated
| const responseStatus = req.headers['x-give-response-status'] || 200; | ||
| const responseStatus = parseInt(req.headers['x-give-response-status'] || "200"); |
There was a problem hiding this comment.
Good catch, just a tiny nitpick - could this be const responseStatus = parseInt(req.headers['x-give-response-status']) || 200 instead?
This is required to be an int, so make it an int on construction.
pjonsson
force-pushed
the
test-deprecation-fixes
branch
from
743841f to
a3b1ece
Compare
na9da
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.