-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1757 tm new routing #342
1757 tm new routing #342
Conversation
# Conflicts: # package.json
Also remove appBaseUrl default
# Conflicts: # package-lock.json # package.json # yarn.lock
OK @kring this is ready now, I don't know if we want travis to attempt prerendering as part of the build or just skip it for CI:
Working CI test can be seen @ #349 - the only material difference is pointing to the right |
@@ -1,10 +1,11 @@ | |||
<!DOCTYPE html> | |||
<html lang="en" class="terria"> | |||
<head> | |||
<base href="/"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually now index.html gets updated as part of the render-datasource-templates
gulp task, should we remove this from source to avoid confusion?
to redev/review after mobx |
# Conflicts: # package.json
See: TerriaJS/terriajs#3494
Still to do
generate-init-routes.js
Also see:
TerriaJS/terriajs-server#106