Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow users to replace connection urls to connect queues behind proxy #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qhuangd
Copy link

@qhuangd qhuangd commented Aug 5, 2020

Motivation

TDMQ currently can only be accessed inside the same VPC. This PR allows users to set-up a proxy in front of it, and access it through proxy.

Modifications

Add PatchConnURL func(*url.URL) to pulsar.ClientOptions, which will allow users to modify physicalAddr before connecting

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (yes)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)

The changes are backward-compatible, it's an additional and optional field to ClientOptions

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (GoDocs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant