Refactor FluentExtensions.Switch to use equality comparers instead of requiring IEquatable<T> implementation #67
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Louis.Fluency.FluentExtensions.Switch
, useEqualityComparer<T>.Default
instead of requiring that values being compared implementIEquatable<T>
. This will allow enums to be used as values and comparands. Enums do not implementIEquatable<T>
for compatibility reasons, as they predate generics.FluentExtensions.Switch
overloads that let the user specify anIEqualityComparer<T>
interface.Checklist of related issues / discussions
As the issue with
FluentExtensions.Switch
not working with enums surfeced in production while on a strict deadline, there was unfortunately no time to open a proper issue.Types of changes
This pull request introduces the following types of changes:
docs
directory) update.gitattributes
,.gitignore
)Breaking changes
This pull request introduces breaking changes:
Checklist
docs
directory) only: