-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loading bar issue Has been resolved issue no. 343 #343 #347
base: master
Are you sure you want to change the base?
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @Tejas1510 on Vercel. @Tejas1510 first needs to authorize it. |
@heet-kumar is the server not working issue resolved in this pr itself? |
yes resolved about the Loading bar |
@ChitvanRamani22 loading bar issue resolved |
@heet-kumar i m asking about that server error? |
server error it is showing its god because when your network is down that time it shows Server Not responding . |
@ChitvanRamani22 check this above one commit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heet-kumar Buddy it would be nice if in the description you mention the issue number
and also include the screenshots of how it was before and how it is now
It will be easy for you as well as for us
done sir I apologies for inconvenience . here in the above I have given intentionally random/correct email id dosen't matter I have checked that in both email id , but the loading bar appears on the sign-in and sign-up buttons that dosen't looks good that issue I have resolved . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heet-kumar Buddy tell me one thing , I agree that loading bar doesn't look good when the email is wrong or something like that.
But what in the case where the credentials are right , in that case also the loading bar will not appear as you have removed the import line and also that " LinearProgress " component
Other than this , what I think is : " Server is not responding " error is not occuring like you said : in the localhost its appearing ,but in the deployed version , it will not show
Its not like that , if server is not running , whether its localhost or deployed version , it will not run
But if it's running it will be running both in localhost and deployed version. So I think you need to understand this , leme know if you have any doubts or something
@Jassi10000 bro don't mind it I have just want to let you know that already error features are there like if credentials are correct then it will not display any type of error in the below white space or If credential are wrong then It will display type of that particular error in below white space given . I apologies if you mind it . |
@heet-kumar No buddy , not an issue |
@Jassi10000 No I didn't found any another way to resolve it I think in my point of view which I have provided that is correct . |
Buddy , it would be nice if you come on a meet , let' continue the further convo on discord |
@Jassi10000 ya Sure brother why not |
Jassi | M#8109 <-- discord username |
@Tejas1510 @sanjay270899 @Jassi10000 |
Sure , @heet-kumar we will have a look over this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@heet-kumar
Buddy please resolve the merge conflicts
issue no. 343 #343
I have removed the loading bar which appear on the Log-In and Sign-up buttons while clicking on that . It does not look attractive to the users for their experience .