Fix up video processing

lib/mosquito.rb

@@ -49,25 +49,23 @@ def self.tweet_fields
 
   # Get media from a URL and save to a temp folder set in the configuration under
   # temp_storage_location
-  def self.retrieve_media(url)
+  def self.retrieve_media(url, extension: nil)
     return "" if url.nil?
     return "" if !Mosquito.save_media
 
     response = Typhoeus.get(url)
 
     # Get the file extension if it's in the file
-    begin
+    if extension.nil?
       extension = url.split(".").last
-    rescue StandardError => e
-      debugger
-    end
 
-    # Do some basic checks so we just empty out if there's something weird in the file extension
-    # that could do some harm.
-    if extension.length.positive?
-      extension = extension[0...extension.index("?")]
-      extension = nil unless /^[a-zA-Z0-9]+$/.match?(extension)
-      extension = ".#{extension}" unless extension.nil?
+      # Do some basic checks so we just empty out if there's something weird in the file extension
+      # that could do some harm.
+      if extension.length.positive?
+        extension = extension[0...extension.index("?")]
+        extension = nil unless /^[a-zA-Z0-9]+$/.match?(extension)
+        extension = ".#{extension}" unless extension.nil?
+      end
     end
 
     temp_file_name = "#{Mosquito.temp_storage_location}/#{SecureRandom.uuid}#{extension}"

lib/mosquito/scrapers/tweet_scraper.rb

@@ -55,15 +55,15 @@ def parse(id)
       # Video
       nodes = doc.xpath("//div[contains(@class, 'main-tweet')]/div/div/div[contains(@class, 'attachments')]/div[contains(@class, 'gallery-video')]/div/video")
       unless nodes.empty?
-        video_preview_image = nodes.first["poster"]
-        videos.concat(nodes.map { |node| "#{Capybara.app_host}#{node.xpath("//source").first["src"]}" })
+        video_preview_image = Mosquito.retrieve_media("#{Capybara.app_host}#{nodes.first["poster"]}", extension: ".jpg")
+        videos.concat(nodes.map { |node| Mosquito.retrieve_media(node.xpath("//source").first["src"]) })
         video_file_type = "video" # This is always video now, sing a gif isn't displayed differently
       end
 
       # GIF
       nodes = doc.xpath("//div[contains(@class, 'main-tweet')]/div/div/div[contains(@class, 'attachments')]/div[contains(@class, 'gallery-gif')]/div/video")
       unless nodes.empty?
-        video_preview_image = nodes.first["poster"]
+        video_preview_image = Mosquito.retrieve_media(nodes.first["poster"], extension: ".jpg")
         videos.concat(nodes.map { |node| Mosquito.retrieve_media("#{Capybara.app_host}#{node.xpath("//source[1]/source/@src").first&.content}") })
         video_file_type = "gif"
       end