Obtain stream length as a Duration #1106
Open
+94
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
the
codequality
Isira-Seneviratne
force-pushed
the
Duration
branch
from
5c3115b
to
534e2a3
Compare
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItemExtractor.java
Outdated
Show resolved
Hide resolved
extractor/src/main/java/org/schabi/newpipe/extractor/localization/TimeAgoParser.java
Outdated
Show resolved
Hide resolved
TobiGr
reviewed
Dec 29, 2023
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java
Show resolved
Hide resolved
TobiGr
reviewed
Dec 29, 2023
extractor/src/main/java/org/schabi/newpipe/extractor/stream/StreamInfoItem.java
Outdated
Show resolved
Hide resolved
Isira-Seneviratne
force-pushed
the
Duration
branch
from
534e2a3
to
335875d
Compare
|
I made some changes, this should no longer break existing uses of the methods. |
Isira-Seneviratne
force-pushed
the
Duration
branch
2 times, most recently
from
1ab1a80
to
3111454
Compare
Isira-Seneviratne
force-pushed
the
Duration
branch
from
3111454
to
0261e63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract stream lengths as
Durationvalues.Durationprovides convenience methods for converting to/from different time units, e.g. seconds, hours, etc.Note: Previously, the existing methods' types were updated to
Duration, which would have required changes in existing uses. To maintain compatibility, this PR has been updated to retain the existing methods and update them to call the new methods.