Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved player notification setting to notification section #9580

Merged
merged 1 commit into from
Mar 30, 2024
Merged

Moved player notification setting to notification section #9580

merged 1 commit into from
Mar 30, 2024

Conversation

pratyaksh1610
Copy link
Contributor

@pratyaksh1610 pratyaksh1610 commented Dec 21, 2022 •
edited by Stypox
Loading

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

Moved player notification setting to notification section

Before/After Screenshots/Screen Record

Before After
before.mp4
afterr.mp4

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.

Due diligence

@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@SameenAhnaf SameenAhnaf added the bug Issue is related to a bug label Dec 21, 2022
@SameenAhnaf SameenAhnaf mentioned this pull request Dec 23, 2022
Open
6 tasks
@SameenAhnaf
Copy link
Collaborator

SameenAhnaf commented Dec 24, 2022 •
edited
Loading

You should put Player Notifications above New Stream Notifications instead. Because, these options are related to each other.

IMG_20221224_214446

@Stypox Stypox added waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. and removed waiting for author If the author doesn't respond, the issue will be auto-closed. Otherwise the label will be removed. labels Jan 1, 2023
@Stypox
Copy link
Member

Stypox commented Jan 1, 2023

(sorry my mistake, I forgot about #9587)

@XilinJia
Copy link

XilinJia commented Mar 4, 2024

This seems like not ready for review? Still need author to respond.

@opusforlife2
Copy link
Collaborator

Settings will be redesigned by #10849, so we don't need to care about that here.

@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Mar 30, 2024
Stypox
Stypox approved these changes Mar 30, 2024
View reviewed changes
Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Stypox Stypox enabled auto-merge March 30, 2024 14:27
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Stypox Stypox merged commit 58f5ec0 into TeamNewPipe:dev Mar 30, 2024
6 checks passed
@Stypox Stypox mentioned this pull request Apr 1, 2024
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Stypox Stypox Stypox approved these changes

Assignees
No one assigned
Labels
bug Issue is related to a bug size/small PRs with less than 50 changed lines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Player Notifications setting into Notifications section
5 participants
@pratyaksh1610 @SameenAhnaf @Stypox @XilinJia @opusforlife2