Added Playlist and video names to local playlist sharing #9060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed! |
opusforlife2
added
feature request
Stypox
requested changes
Nov 29, 2022
Comment on lines
+387
to
+388
| .subscribe(urlsText -> ShareUtils.shareText( | ||
| requireContext(), name, name + " \n\n" + urlsText), |
There was a problem hiding this comment.
I would undo this part of the change. Sharing text on Android already provides the title and content fields, so you shouldn't add the title at the beginning of the content again.
| .map(StreamEntity::getUrl) | ||
| .collect(Collectors.joining("\n")))) | ||
| .map(streamEntity -> streamEntity.getTitle() + " " + streamEntity.getUrl()) | ||
| .collect(Collectors.joining("\n\n")))) |
There was a problem hiding this comment.
I would also undo this: why two newlines?
Suggested change
| .collect(Collectors.joining("\n\n")))) | |
| .collect(Collectors.joining("\n")))) |
| @@ -381,10 +381,11 @@ public void sharePlaylist() { | |||
| disposables.add(playlistManager.getPlaylistStreams(playlistId) | |||
| .flatMapSingle(playlist -> Single.just(playlist.stream() | |||
| .map(PlaylistStreamEntry::getStreamEntity) | |||
| .map(StreamEntity::getUrl) | |||
| .collect(Collectors.joining("\n")))) | |||
| .map(streamEntity -> streamEntity.getTitle() + " " + streamEntity.getUrl()) | |||
There was a problem hiding this comment.
I think it is better to swap title and URL, since URLs are usually all the same length, while titles are not. This way the urls would somewhat align better and be easier to click, and titles would still all start roughly from the same column. Anyway, if you disagree with me it's fine, we can keep it as it is.
6 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
-Updated the string generated when sharing a local playlist. It now includes the playlist name, and video titles.
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR.
Due diligence