Implement splash screen using Core Splashscreen library #11710
+26
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Isira-Seneviratne
force-pushed
the
Splash-screen
branch
from
b090bdd
to
d424656
Compare
opusforlife2
added
rewrite
|
Can you test on a Samsung devices ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
This PR implements the app splash screen using the Core Splashscreen library. This allows a splash screen similar to that automatically generated on Android 12 and later to be displayed on older versions of Android.
More information on Android 12's splash screen functionality: Splash screens
Before/After Screenshots/Screen Record
All versions of Android:
Screen_recording_20241116_143747.mp4
Android 5.0
Screen_recording_20241116_143153.webm
Android 6.0
Screen_recording_20241116_143343.webm
Android 15 (light theme)
Screen_recording_20241116_143511.mp4
Android 15 (dark theme)
Screen_recording_20241116_143534.mp4
Fixes the following issue(s)
APK testing
The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.
Due diligence