Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only start playing single item in history screen #11696

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

codyit
Copy link
Contributor

@codyit codyit commented Nov 12, 2024

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • Holding an item in history and clicking "Start playing in the background" would now only add the current item in the play queue, instead of the full history which is usually massive.

Before/After Screenshots/Screen Record

N/A

Fixes the following issue(s)

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

…ground" would only enqueue the current item instead of the full history which is usually massive
@github-actions github-actions bot added the size/small PRs with less than 50 changed lines label Nov 12, 2024
@codyit codyit marked this pull request as ready for review November 12, 2024 05:47
@Stypox
Copy link
Member

Stypox commented Nov 12, 2024

There are people that rely on this behavior (me included) and last time we changed something we got a lot of angry users. During the refactor we will look into redesigning the long-press menu to allow for all of these different options to co-exist (starting without enqueueing everything and starting a playlist from a specific item), but we can't just change one thing without thinking about the whole picture. Sorry about it, and thank you for your contribution anyway.

@Stypox Stypox closed this Nov 12, 2024
@Stypox Stypox reopened this Nov 12, 2024
@Stypox
Copy link
Member

Stypox commented Nov 12, 2024

Oh wait, you are just doing the change for the history fragment. Then I think the change makes sense.

Copy link
Member

@Stypox Stypox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Stypox Stypox changed the title Remove history dialog override so clicking "Start playing in the background" would only enqueue the current item instead of the full history which is usually massive Only start playing single item in history screen Nov 12, 2024
@Stypox Stypox merged commit a229ab6 into TeamNewPipe:dev Nov 12, 2024
6 checks passed
Copy link

sonarcloud bot commented Nov 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Issue is related to a feature in the app history Anything to do with previously watched stuff queue Issue is related to queueing size/small PRs with less than 50 changed lines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants