Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to change font feature #11645

Closed
wants to merge 8 commits into from
Closed

Option to change font feature #11645

wants to merge 8 commits into from

Conversation

u7648330
Copy link

What is it?

  • Bugfix (user facing)
  • Feature (user facing)
  • Codebase improvement (dev facing)
  • Meta improvement to the project (dev facing)

Description of the changes in your PR

  • giving the option to change font in Setting - Content
  • change the font of headings, contents and search

Before/After Screenshots/Screen Record

  • Before:
    image

  • After:
    image

Fixes the following issue(s)

APK testing

I tested the APK using the Android Studio Emulator with the following steps:

  • Installed the APK on the emulator running Android 13.
  • Verified that users can change font from Setting -> Content.
  • Checked that there is a Toast prompting the user to restart the app after the user clicked changing font and exited Content page.
  • Ensured the there is a font change after restarting the app
  • Confirmed no crashes or unexpected behavior during testing.

Due diligence

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Oct 26, 2024
@TobiGr
Copy link
Member

TobiGr commented Oct 27, 2024

Thank you for your PR. Due to the influx of new PRs review might take some time. Please let me know if you are an ANU student for internal statistics and because I am writing my master thesis about open source contributions as part of learning computer science and computer science education at university.

@u7648330
Copy link
Author

u7648330 commented Oct 27, 2024 via email

@Stypox
Copy link
Member

Stypox commented Nov 12, 2024

NewPipe is currently in maintenance mode and is not accepting PRs for new features, as explained on top of the README, especially niche features like this one. Moreover, customizing fonts is off-topic for NewPipe, I now closed the original issue, too. Thank you anyway for your contribution!

@Stypox Stypox closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/giant PRs with more than 750 changed lines
Projects
Status: Rejected
Development

Successfully merging this pull request may close these issues.

custom font
3 participants