Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI crash when user navigates away before the download dialog appears #11621

Merged
merged 7 commits into from
Nov 2, 2024
Merged

Fix UI crash when user navigates away before the download dialog appears #11621

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
53edd05
Project now runs
u7656655 Oct 17, 2024
0cf4732
Fix UI crash when user navigates away before the download dialog appears
elvakang Oct 19, 2024
2eb2567
Revert "Project now runs"
elvakang Oct 19, 2024
63bc982
Merge branch 'TeamNewPipe:dev' into fixing-ui-crash-11468
elvakang Oct 24, 2024
1ed4928
Add comment for fragment lifecycle checks before showing DownloadDialog
elvakang Oct 24, 2024
0190bce
Fix line length violation
elvakang Oct 24, 2024
f4baf46
Update app/src/main/java/org/schabi/newpipe/info_list/dialog/StreamDi…
TobiGr Oct 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/src/main/java/org/schabi/newpipe/info_list/dialog/StreamDialogDefaultEntry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ public enum StreamDialogDefaultEntry {
DOWNLOAD(R.string.download, (fragment, item) ->
fetchStreamInfoAndSaveToDatabase(fragment.requireContext(), item.getServiceId(),
item.getUrl(), info -> {
if (fragment.getContext() != null) {
// Ensure the fragment is attached and its state hasn't been saved to avoid
// showing dialog during lifecycle changes or when the activity is paused.
TobiGr marked this conversation as resolved.
Show resolved Hide resolved
if (fragment.isAdded() && !fragment.isStateSaved()) {
final DownloadDialog downloadDialog =
new DownloadDialog(fragment.requireContext(), info);
downloadDialog.show(fragment.getChildFragmentManager(),
Expand Down
Loading