Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix related items list enqueue popup crash #11614

Merged
merged 5 commits into from
Nov 3, 2024
Merged

Fix related items list enqueue popup crash #11614

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
781a69d
Chanegd related videos enqueue modal to attach to parent fragment ins…
rmtilde Oct 16, 2024
b14f658
Added comments to explain changes
rmtilde Oct 16, 2024
678f0a7
Merge pull request #1 from rmtilde/fix-related-items-enqueue-on-video…
rmtilde Oct 17, 2024
1996c11
Merge branch 'TeamNewPipe:dev' into fix-related-items-enque-popup-crash
rmtilde Oct 26, 2024
66ec596
Update app/src/main/java/org/schabi/newpipe/fragments/list/videos/Rel…
rmtilde Nov 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions app/src/main/java/org/schabi/newpipe/fragments/list/videos/RelatedItemsFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import androidx.fragment.app.Fragment;
import androidx.preference.PreferenceManager;

import org.schabi.newpipe.R;
Expand All @@ -18,8 +19,10 @@
import org.schabi.newpipe.extractor.InfoItem;
import org.schabi.newpipe.extractor.ListExtractor;
import org.schabi.newpipe.extractor.stream.StreamInfo;
import org.schabi.newpipe.extractor.stream.StreamInfoItem;
import org.schabi.newpipe.fragments.list.BaseListInfoFragment;
import org.schabi.newpipe.info_list.ItemViewMode;
import org.schabi.newpipe.info_list.dialog.InfoItemDialog;
import org.schabi.newpipe.ktx.ViewUtils;

import java.io.Serializable;
Expand Down Expand Up @@ -173,4 +176,27 @@ protected ItemViewMode getItemViewMode() {
}
return mode;
}

@Override
protected void showInfoItemDialog(final StreamInfoItem item) {
// Try and attach the InfoItemDialog to the parent fragment of the RelatedItemsFragment
// so that its context is not lost when the RelatedItemsFragment is reinitialized,
// e.g. when a new stream is loaded in a parent VideoDetailFragment.
final Fragment parentFragment = getParentFragment();
if (parentFragment != null) {
try {
new InfoItemDialog.Builder(
parentFragment.getActivity(),
parentFragment.getContext(),
parentFragment,
item
).create().show();
} catch (final IllegalArgumentException e) {
InfoItemDialog.Builder.reportErrorDuringInitialization(e, item);
}
} else {
super.showInfoItemDialog(item);
}
}

}
Loading