Adding Hash of Signing Key to README #11140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will have to be kept track of and updated on every new release. Is there no way to automate this? |
|
The hash of the signing key should remain consistent between releases.
…-------- Original Message --------
On 6/7/24 11:06 AM, opusforlife2 wrote:
Forwarded by SimpleLogin to ***@***.*** from "opusforlife2 " with Re: [TeamNewPipe/NewPipe] Adding Hash of Signing Key to README (PR #11140) as subject
This will have to be kept track of and updated on every new release. Is there no way to automate this?
—
Reply to this email directly, [view it on GitHub](#11140 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AOEXTBTIISAESTM6FQTPEPLZGHK6VAVCNFSM6AAAAABI6ZV452VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGEZDSNJTGM).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
Oh, my bad, I was thinking of the hash of the APK. |
|
No problem. Correct, it's not the hash of the apk itself.
…-------- Original Message --------
On 6/7/24 11:31 AM, opusforlife2 wrote:
Forwarded by SimpleLogin to ***@***.*** from "opusforlife2 " with Re: [TeamNewPipe/NewPipe] Adding Hash of Signing Key to README (PR #11140) as subject
Oh, my bad, I was thinking of the hash of the APK.
—
Reply to this email directly, [view it on GitHub](#11140 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AOEXTBUJLPDFDSXUE4DCO6LZGHN7VAVCNFSM6AAAAABI6ZV452VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJVGE3DOOJVGE).
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description of the changes in your PR
For your consideration, I'm submitting a small edit to the README to add the hash of the signing key currently posted on the NewPipe website and bring it to the user's attention in installation method #2.
For android users looking to download the APK and install directly from Github, or using a different method like Obtainium, the responsibility of verifying the signing key of the downloaded APK is placed on the user. This is easily done with AppVerifier. A signing certificate posted on both the website and in the README would improve user confidence in the download.
Thank you for your consideration.